| |
spider-j
Registered: Oct 2004
Posts: 498 |
Release id #216054 : GTUltra V1.0.3
Better take this to discussions to not flood the comments.
Quote:Can you run it from the win32 folder?
Running the exe through WINE works fine. I'd prefer a native linux build though. |
|
... 159 posts hidden. Click here to view all posts....
|
| |
tlr
Registered: Sep 2003
Posts: 1787 |
Quote: what confuses me is that I know that these files have 0xd,0xa as LF,CF - I can see it in a hex editor, and I'm loading in binary, so this should stay the same. So the code that is there already should handle this correctly...What have I missed here?!
You are missing that they are text files. git cloning text files will yield native line endings on the platform the clone is performed on. |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
Hah!
Yes, I missed that!
I had no idea that GIT would mess around with file data! I thought the rb / me parsing the data should mean that the data is 100% the same for you as it is for me. That's pretty shocking... However, how does GIT know that they're text files? Just by a binary search? Surely that's really dangerous? it could just decide that something is a text file, even though it wasn't?...Time for a google search..
(Likelyhood is that I'll ditch the text format and revert to at least having binary data for palette files..) |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
Also - I just wanted to say that I REALLY appreciate your help here!
Thank you |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
@tlr - OK, so now I understand what's going wrong (I'm blaming GIT here ;) - When you change the check to 0xa, that should then fix everything... But you're still not getting different palettes?
EDIT: Is it possible for you to upload one of the .gtp files to here:
https://www.dropbox.com/scl/fo/1vaevbxbohrmzxghyhxg2/h?dl=0&rlk..
Would like to just verify that my changes to the text parser works.
Thanks! |
| |
tlr
Registered: Sep 2003
Posts: 1787 |
Quoting Jason PageI had no idea that GIT would mess around with file data! I thought the rb / me parsing the data should mean that the data is 100% the same for you as it is for me. That's pretty shocking... Well, if it didn't convert it would be a horrible pain to work on the same code from two different platforms.
Quoting Jason PageHowever, how does GIT know that they're text files? Just by a binary search? Surely that's really dangerous? it could just decide that something is a text file, even though it wasn't?...Time for a google search..
I guess that is something Mr Torvalds has to explain. :)
Text file conversion to native line endings is the default in most revision control tools but commonly you have to explicitly tell the tools when to treat files as binaries. Git does it automatically.
Quoting Jason Page@tlr - OK, so now I understand what's going wrong (I'm blaming GIT here ;) - When you change the check to 0xa, that should then fix everything... But you're still not getting different palettes?
with my crude tweaks I get different palettes, yes.
EDIT: files here: gtpalettes.zip (unless zip converts them too :) |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
I can't download for some reason... The gods of code hate me today. can you copy to that dropbox folder?
EDIT: Ignore that. Chrome wasn't happy. Edge (urgh...) complained but eventually gave me the file. Thanks |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
Super..
So, changing the magic line to:
if ((**strp == 0xa) || (**strp == 0xd))
{
Allows for both to work.
Apart from that change, what else did I need to change so that it compiles / works out of the box? Was there a change to the file path too?
I'll commit that change anyway ^^^ |
| |
tlr
Registered: Sep 2003
Posts: 1787 |
Quote: Super..
So, changing the magic line to:
if ((**strp == 0xa) || (**strp == 0xd))
{
Allows for both to work.
Apart from that change, what else did I need to change so that it compiles / works out of the box? Was there a change to the file path too?
I'll commit that change anyway ^^^
You need to separate the concept of the path to the binary/installation from the concept of the path to the config file.
Also there was a "\\" in loadPalettes() that needs to be "/". |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
Yeah, I fixed the // to \ thing before. I think you missed that push. Hopefully what's there works now? |
| |
tlr
Registered: Sep 2003
Posts: 1787 |
Quote: Yeah, I fixed the // to \ thing before. I think you missed that push. Hopefully what's there works now?
Assuming I copy the gtpalettes directory to the config directory it seems to work. Can't say if the actual themes are 100% like intended, but they are all different. |
| Previous - 1 | ... | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 - Next |
