| |
spider-j
Registered: Oct 2004
Posts: 445 |
Release id #216054 : GTUltra V1.0.3
Better take this to discussions to not flood the comments.
Quote:Can you run it from the win32 folder?
Running the exe through WINE works fine. I'd prefer a native linux build though. |
|
... 159 posts hidden. Click here to view all posts....
|
| |
tlr
Registered: Sep 2003
Posts: 1714 |
Quoting Jason PageI had no idea that GIT would mess around with file data! I thought the rb / me parsing the data should mean that the data is 100% the same for you as it is for me. That's pretty shocking... Well, if it didn't convert it would be a horrible pain to work on the same code from two different platforms.
Quoting Jason PageHowever, how does GIT know that they're text files? Just by a binary search? Surely that's really dangerous? it could just decide that something is a text file, even though it wasn't?...Time for a google search..
I guess that is something Mr Torvalds has to explain. :)
Text file conversion to native line endings is the default in most revision control tools but commonly you have to explicitly tell the tools when to treat files as binaries. Git does it automatically.
Quoting Jason Page@tlr - OK, so now I understand what's going wrong (I'm blaming GIT here ;) - When you change the check to 0xa, that should then fix everything... But you're still not getting different palettes?
with my crude tweaks I get different palettes, yes.
EDIT: files here: gtpalettes.zip (unless zip converts them too :) |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
I can't download for some reason... The gods of code hate me today. can you copy to that dropbox folder?
EDIT: Ignore that. Chrome wasn't happy. Edge (urgh...) complained but eventually gave me the file. Thanks |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
Super..
So, changing the magic line to:
if ((**strp == 0xa) || (**strp == 0xd))
{
Allows for both to work.
Apart from that change, what else did I need to change so that it compiles / works out of the box? Was there a change to the file path too?
I'll commit that change anyway ^^^ |
| |
tlr
Registered: Sep 2003
Posts: 1714 |
Quote: Super..
So, changing the magic line to:
if ((**strp == 0xa) || (**strp == 0xd))
{
Allows for both to work.
Apart from that change, what else did I need to change so that it compiles / works out of the box? Was there a change to the file path too?
I'll commit that change anyway ^^^
You need to separate the concept of the path to the binary/installation from the concept of the path to the config file.
Also there was a "\\" in loadPalettes() that needs to be "/". |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
Yeah, I fixed the // to \ thing before. I think you missed that push. Hopefully what's there works now? |
| |
tlr
Registered: Sep 2003
Posts: 1714 |
Quote: Yeah, I fixed the // to \ thing before. I think you missed that push. Hopefully what's there works now?
Assuming I copy the gtpalettes directory to the config directory it seems to work. Can't say if the actual themes are 100% like intended, but they are all different. |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
Should match what was in the video link I posted earlier |
| |
theK
Registered: Oct 2020
Posts: 44 |
Just got back, you guys are hard at work! :-O
Latest build still get "./gtultra
/home/xxx/.goattrk/gtpalettes: No such file or directory"
It goes to the wrong folder. The gtpallets is in the "binary" folder, not the config one. |
| |
Jason Page
Registered: Sep 2015
Posts: 87 |
I'm going to change the code so that it looks for gtpalette folder in $HOME/.goattrk/
Please confirm this is correct |
| |
tlr
Registered: Sep 2003
Posts: 1714 |
Quote: I'm going to change the code so that it looks for gtpalette folder in $HOME/.goattrk/
Please confirm this is correct
This is what it does now. It sort of makes sense, because it is configuration after all. The issue is that there is no gtpalettes/ folder there when starting up the first time. Either you have the palettes looked up where the binary is, or you write out the initial defaults to $HOME/.goattrk if no gtpalettes exist.
The latter is the nicest IMO. |
| Previous - 1 | ... | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18 - Next |
