| |
JCH
Registered: Aug 2008
Posts: 200 |
SID Factory II
Laxity and I have decided to go BETA with SID Factory II to let all curious SID composers also have a go at this cross-platform SID editor.
We have a Facebook group that you are welcome to join. There's also a nifty user manual there. If you're not on Facebook, this thread should serve as another place where we can share questions, ideas, music, bugs, new builds, additional files, etc.
Please note that although SID Factory II is quite stable and more than capable of editing SID tunes at this point, it is still missing a few essential things such as e.g. sub tunes. We have a solid ToDo and will post new builds here as they become available.
The first official BETA build: SIDFactoryII_20200604.zip |
|
... 145 posts hidden. Click here to view all posts....
|
| |
Youth
Registered: Aug 2003
Posts: 43 |
Quoting Groepazgreat! should i send you a pull request with the missing makefiles and the gpl? :)
Please have a look in the 'linux' branch on Github. There is a Makefile in the root. I also incorporated your changes in the linux specific platform file.
Was hoping to include an official linux build, but I could not properly test it in my virtual ubuntu environment. Especially the keybindings; for macOS we needed to override a few of the bindings, maybe we need to do the same for linux? If someone could test if all the bindings work or some need replacing, JCH can also make the proper overlay images, which are also os specific.
Any help/feedback on linux build would be appreciated! |
| |
Youth
Registered: Aug 2003
Posts: 43 |
Quoting CompyxHow do I build on Linux? Seems it's very windows-centric? Seems there's two Makefile's for MacOS.
Please have a look in the 'linux' branch on Github. No instructions yet, but 'make dist' should do the trick.
Please note that overlays do not work yet as their content is os specific and we do not know if all the keybindings are in their proper place.
There is one separate Makefile for macos in the /macos folder with specific macOS app bundling stuff. There is duplication which can probably be improved later. I see there is an old Makefile in the SF2Converter but you can discard that. The one in the root builds sf2 and sf2converter.
Feedback appreciated ;) |
| |
Compyx
Registered: Jan 2005
Posts: 631 |
After doing a 'git checkout linux' I did manage to build a Linux binary.
You might consider changing a few variables in the Makefile:
CC is meant to contain the C compiler, not the C++ compiler, so you should use CXX
You also use CC_FLAGS, which is non-standard, nothing wrong with that, but the standard would be CXXFLAGS (CFLAGS for C).
Same with LINKER_FLAGS, the standard variable would be LDFLAGS. And for linking perhaps use $(LD) and add 'LD=$(CXX)' in the Makefile after 'CXX=g++'.
Nitpicking, I know, but it would make it easier for people to override the compiler, linker and flags in a standard way :) |
| |
JackAsser
Registered: Jun 2002
Posts: 2014 |
Quote: After doing a 'git checkout linux' I did manage to build a Linux binary.
You might consider changing a few variables in the Makefile:
CC is meant to contain the C compiler, not the C++ compiler, so you should use CXX
You also use CC_FLAGS, which is non-standard, nothing wrong with that, but the standard would be CXXFLAGS (CFLAGS for C).
Same with LINKER_FLAGS, the standard variable would be LDFLAGS. And for linking perhaps use $(LD) and add 'LD=$(CXX)' in the Makefile after 'CXX=g++'.
Nitpicking, I know, but it would make it easier for people to override the compiler, linker and flags in a standard way :)
Nitpicking aside, this is proper nitpicking.
Never seen LD assigned to CXX though |
| |
Youth
Registered: Aug 2003
Posts: 43 |
Quoting Compyx
Nitpicking, I know, but it would make it easier for people to override the compiler, linker and flags in a standard way :)
I have only limited linux/c++/makefile experience so I am not surprised the Makefile is flawed :) Once I had the macOS build I thought I could have a go at extending the experience I had from that to a linux build.
But since neither Laxity, JCH or myself actually use linux, we will not find issues ourselves or be able to properly fix and test them, so input and pull requests are welcome! |
| |
Compyx
Registered: Jan 2005
Posts: 631 |
Quote: Nitpicking aside, this is proper nitpicking.
Never seen LD assigned to CXX though
We use g++ or clang++ as a linker for vice, otherwise vte won't link, usually though LD=$(CC) should work fine. |
| |
Compyx
Registered: Jan 2005
Posts: 631 |
Quote: Quoting Compyx
Nitpicking, I know, but it would make it easier for people to override the compiler, linker and flags in a standard way :)
I have only limited linux/c++/makefile experience so I am not surprised the Makefile is flawed :) Once I had the macOS build I thought I could have a go at extending the experience I had from that to a linux build.
But since neither Laxity, JCH or myself actually use linux, we will not find issues ourselves or be able to properly fix and test them, so input and pull requests are welcome!
You may want to start with merging the 'linux' branch into master. Having to check out a separate branch (which is out of sync) for Linux feels weird. |
| |
chatGPZ
Registered: Dec 2001
Posts: 11386 |
Quote:You may want to start with merging the 'linux' branch into master.
this :)
as for distribution - i wouldnt bother much. just make sure it builds correctly. packaging is usually up to those who make the distros. it shouldnt be required for something simple like this either. if you really care, a proper "make install" target is the way to go, imho - but it will require configuration options for various things. i'd rather fix the code so a plain binary distribution works from whatever location. |
| |
Youth
Registered: Aug 2003
Posts: 43 |
Quoting GroepazQuote:You may want to start with merging the 'linux' branch into master.
this :)
Done. Linux branch is merged to master. Good luck ;) |
| |
chatGPZ
Registered: Dec 2001
Posts: 11386 |
Compiles with almost zero warnings (just some harmless "unchecked return values of fread"), and works fine from the "artifacts" directory after "make dist". i think you can just zip that up for an oldschool binary distribution, leave more sophisticated packaging to whoever wants to do it =P |
| Previous - 1 | ... | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 - Next |
