| |
Skoe
Account closed
Registered: Jan 2008
Posts: 34 |
Release id #76119 : MultiColour V0.1.1
These are the answers to the comments at MultiColor V0.1.1
@Majikeyric: I just saw that the color selection doesn't work correctly in the windows version. I should have tested it more carefully :/ Normally one should be able to use the right mouse button to select a secondary color and then draw with the right button.
@Ninja: I really appreciate patches as long as they fit to the zlib-License (no GPL, please) and as long as I like them =) Feel free to contact me using mail or the Berlios tools. Maybe better before you implement something to be sure the work isn't done twice.
Regarding installing it on Linux: I used a Xubuntu 8.10 live CD to test it. The package manager automatically installed libwxgtk2.8 and libwxbase2.8. However, for other distros I also recommend to build it from sources. It's easy:
1. install libwxgtk2.8-dev or whatever name it has on your system. This will hopefully also install all other dependencies like libwxbase2.8-dev
2. compile (as normal user)
cd make/gcc-default
make
3. install (optional, as root)
sudo make install
Step 3 should even create a menu entry for Gnome, KDE or Xfce. I'll add an INSTALL file in the next release.
Before adding new "high level" features I'm planning to optimize and improve the already existing ones first:
- Fix the win32 issues (secondary color, screen update, crash on exit)
- Some algorithmical optimizations of the really stupid drawing/update code
- Currently it's much slower than it should be
- Color picker (using Shift is a good idea)
- Keyboard shortcuts
- Use scroll weel to zoom
When this is done some more useful features could be added like Copy & Paste, real PAL emulation and so on.
|
|
| |
Skoe
Account closed
Registered: Jan 2008
Posts: 34 |
@Deekay
You had problems compiling it on Mac OS X. I don't have a chance to try it and after reading http://www.wxwidgets.org/docs/faqmac.htm I still don't have an idea.
Can you please execute these commands and post the output here:
wx-config --version-full
wx-config --cxxflags
wx-config --libs
Edit: After doing this, let's check if the header files are in the right directories. In MCApp.cpp the file <wx/image.h> is included before the missing <wx/stdpaths.h>.
So please search your hard disk for "image.h" which must be in a directory called "wx" most probably somewere below /usr/include. Where do you find it? When you post this path here, we can think about what's going on in your machine.
Hope you can get it running soon... |
| |
FATFrost
Account closed
Registered: Sep 2003
Posts: 211 |
also this program works fine in osx via crossover, loading and saving and all windows are working too. no problems found so far. |
| |
Edhellon
Registered: Aug 2003
Posts: 22 |
Skoe, it builds fine on OS X 10.5 (intel) using wxwidgets 2.8 from macports. Since the buildsystem produces a unix executable instead of a "proper" app bundle, I had to patch the source a bit to actually be able to give the app focus (it's a wxmac issue not a prob with your stuff). Patch is from http://wiki.wxwidgets.org/WxMac_Issues very crude (was too lazy to create an app bundle). However, it crashes as soon as any file dialog (load/save) would be opened. I didn't have more time to play around with it, but will try to find out why it crashes (kinda limits the usability... :)
Edit: also seemed to have update problems with the small preview widget (on the left) and the editing widget seems to be floating, not docked. |
| |
Skoe
Account closed
Registered: Jan 2008
Posts: 34 |
Sound good. At least a bit.
Quote:Since the buildsystem produces a unix executable instead of a "proper" app bundle,
Maybe later somebody can support me with adding the right things to the source repository. I remember that it was a pain in the a** to build the Debian package...
Quote:I had to patch the source a bit to actually be able to give the app focus (it's a wxmac issue not a prob with your stuff). Patch is from http://wiki.wxwidgets.org/WxMac_Issues very crude (was too lazy to create an app bundle).
I'll try to read this this evening, however it would be great if you could send a patch which makes it running basically. You can contact me by email.
Quote:However, it crashes as soon as any file dialog (load/save) would be opened.
Didn't I mention the license fee you have to pay before using this feature :P ?
Quote:also seemed to have update problems with the small preview widget (on the left) and the editing widget seems to be floating, not docked.
I noticed some update problems on Win32. too. It would be nice if you could make a screenshot and scribble some remarks on it, which parts are not updated and when this happens.
What is the "editing widget"? The main drawing window on the right side which can be zoomed etc? This may look different on different platforms. On GTK it's the tab interface as shown on the screenshot, on windows it's the old style MDI interface with sub-windows.
I like the tab style most. Maybe I'll kick out the MDI crap and implement it using wxNotebook (tabs) so it looks similar on all platforms. On the other hand with this one can only see one image at a time. Will the windows users miss the good old MDI?
|
| |
DeeKay
Registered: Nov 2002
Posts: 363 |
Yep, I was also able to compile it via the Macports wxwidgets (10.4 PPC here) and I also ran into the problem of having no focus on it! ;-)
Hoild: What did you have to do to enable focus? Anyone here capable of turning this into an app bundle? <:-) |
| |
Frantic
Registered: Mar 2003
Posts: 1648 |
There is some kind of custom app-bundle-creating script in the sources for Diskimagery64. There is also something called Platypus, I think, which can be used for creating app bundles if I remember correctly. |
| |
chatGPZ
Registered: Dec 2001
Posts: 11386 |
there is also some hackery in the vice source that creates an .app ...i think :) |
| |
DeeKay
Registered: Nov 2002
Posts: 363 |
As far as I am concerned MDI can go to die a horrible, horrible death in the graveyard of ill concieved Userinterface-Ideas, but i know that for some weird reason that escapes me lots of Windows-Users seem to love it - Which always confirms to me they didn't quite get the concept of having WINDOWS (aka one or more rectangular areas on your desktop that are SMALLER than your actual desktop! 8)... It seems like they're still stuck in the 80s when "multitasking" meant switching from one fullscreen MSDOS app to the next! ;-)
Here's a fact: MDI was originally a MAKESHIFT solution to escape a patent lawsuit from Apple (which never happened in the end due to some crosslicensing deal involving M$ Office), *NOT* a try of making an actually useable UI or to introduce a new (better?) way of doing it!
Well, i guess it just boils down to the good old "It's how I know it..." ;-D |
| |
Skoe
Account closed
Registered: Jan 2008
Posts: 34 |
Having a quick look at the wxMac wiki page linked somewhere above I found some Makefile rules which could be added. Maybe it would be a good idea to copy gcc-default to gcc-macosx or whatever and put the stuff in there. I also found that some minor changes in #ifdef __WXMAC__ must be done.
I'd like to support this as good as I can, but I don't have MacOS X nor time to learn some things about it.
Before copying from vice, remember that it is GPL. Otherwise MultiColor would have a real PAL emulation already :) You can call me nitpicker, but I want it to be clean in this respect.
|
| |
chatGPZ
Registered: Dec 2001
Posts: 11386 |
i could be sneaky and cut out the pal emulation which i rewrote for vice, paste it into a new .c file and release it for you under a bsd license (or whatever, i dont give a damn really =P) |
| |
Skoe
Account closed
Registered: Jan 2008
Posts: 34 |
Ah, the right guy read between the lines :) I think this isn't sneaky but called "dual licensing". |
| |
chatGPZ
Registered: Dec 2001
Posts: 11386 |
it would probably be less work to simply rewrite it from scratch though (the vice rendering queue is.....horrid =D) |
| |
Skoe
Account closed
Registered: Jan 2008
Posts: 34 |
That's why I asked you for some high level documentation some months ago. Because I don't want to read this code. |
| |
Edhellon
Registered: Aug 2003
Posts: 22 |
@DeekaY & @Skoe, I will mail you the patch once I get home. Basically hacked the three lines in the wiki page to MCAPP::Init() or so protected by a #ifdef __APPLE__ / #endif pair.
Obviously an app bundle thingy is the proper way to do it, but for the time being it should be OK. I'm more interested in why it crashes when I try to open a load/save dialog. :)
And yeah, by "editing widget" I mean the main drawing window on the right, which is an MDI window on Mac aswell... :( |
| |
JackAsser
Registered: Jun 2002
Posts: 2014 |
Quote: That's why I asked you for some high level documentation some months ago. Because I don't want to read this code.
Graham was kind to post the specs to Mirage so perhaps you also can have them... |
| |
chatGPZ
Registered: Dec 2001
Posts: 11386 |
grahams filter lacked the odd/even line difference though ... and we have discovered how to emulate another thing (dot creep) now too (thats not even in vice yet) :)
i wouldnt mind to get those specs though, would probably save some work if i can just extend them :) |
| |
DeeKay
Registered: Nov 2002
Posts: 363 |
wow, dot-creep is in there now, too?
Or do you refer to the HMOS/NMOS-bleeding of black that we discussed with Jens and Bero on TUM? 8) I don't see how that's gonna do dot-creep...
Skoe: Great! Looking forward to the patch! ;-D always ready to do beta-testing!... |
| |
chatGPZ
Registered: Dec 2001
Posts: 11386 |
Quote:Or do you refer to the HMOS/NMOS-bleeding of black that we discussed with Jens and Bero on TUM? 8) I don't see how that's gonna do dot-creep...
it's pretty much the same thing :) and no, its not in vice yet, but atleast we know how it works :) |
| |
Skoe
Account closed
Registered: Jan 2008
Posts: 34 |
After some searching I found out that I'm not the first one who makes the file dialog crash:
Please find this line in MCMainFrame.cpp (two times):
stringFilter.append(wxT("All files (*)|*|"));
Does it still crash on MAC OS X after removing the last "|"?
Edit: This helps, got a confirmation. |
| |
DeeKay
Registered: Nov 2002
Posts: 363 |
Okay, making progress here...
Edhellon sent me two patched cpp-files and i was able to compile it on OS X and it runs!
Took me some time to be able to draw for some reason, but it does work. Setting Pixels works, filling works, Linedrawing works and freehand works. No problem choosing the colors. Even opening pictures works as well as saving them, hooray!
Performance however leaves a lot to be desired. There is noticeable drag while drawing, and if the zoomcursor was a dog and your mousepointers was taking it walkies, it would probably need a 200m long leash if you know what I mean! ;-D
Some issues with the window focus: the pixel/zoom area is in another floating window, and there's a 1:1 size preview area in the main window. If I klick anywhere within the main window, the preview area goes black. Only if the zoom-window has focus I can actually see the preview area! I'll post a screenshot, so you know what it looks like on OSX.
Dunno what the blur thingy does (supposedly TV-Emu?), but it doesn't seem to have any effect here. I can switch on and off though, but it doesn't seem to do anything (i zoomed in to verify, there ALWAYS seems to be a slight horizontal blur on the pic!)
Suggestions for improvements: The main window's arrangement is quite "wasty". It needs to have a certain width to be able to see all the tools on the top, and then you have a huge empty area on the right. You WILL need more tools when the app evolves, so you might as well just place them Photoshop/timanthes style vertically in 2 rows on the right of the preview window! ;-)
Here's the screenshot:
|
| |
Steppe
Registered: Jan 2002
Posts: 1510 |
A nice looking XP theme you've got there, DK! |
| |
null
Account closed
Registered: Jun 2006
Posts: 645 |
Steppe likes to live dangerously. ;_D
------------------------------------
http://zomgwtfbbq.info |
| |
JackAsser
Registered: Jun 2002
Posts: 2014 |
Quote: A nice looking XP theme you've got there, DK!
How do you mean? It screams Aqua to me. |
| |
Luca
Registered: Apr 2002
Posts: 178 |
@Skoe: pretty nice tool.
It would be nice too, adding the most common Plus/4 bitmap format: MultiBotticelli's.
What is needed too:
- Multi Botticelli picture format: filenames are prefixed with "M.", e.g. "M.DRAWING"; files are saved from $7800; layout standard:
Color..$7800-$7BE7 ($03E8 bytes, padded to $0400 bytes)
Luminance..$7C00-$7FE7 ($03E8 bytes, padded to $0400 bytes)
Bitmap..........$8000-$9F40 ($1F40 bytes);
signature: the last 6 bytes of the color map (in other words, at $7BFA): "MULT" (FF16 color byte) (FF15 color byte), the FF16 and FF15 color bytes are "nibble-reversed": e.g. $71 value will be stored as $17;
- a valid palette (e.g. Istvan Varga spreaded a nice little tool which produces a palette as .act or .txt files)
- two colors are fixed in the whole pic ($FF15/$FF16), and two can change every 8x8 cell.
|
| |
Skoe
Account closed
Registered: Jan 2008
Posts: 34 |
Quote:and then you have a huge empty area on the right.
This is the area supposed to contain the zoomed view. If you have a look at the screenshot on the release page you'll see that the space is used better in this case. Even if the layout is still far from perfect. One of the next important things is to implement the layout by myself instead of leaving this to wxWidgets.
When I want to reboot my notebook to windows next time I'll have a look at Timanthes, too.
Quote:Performance however leaves a lot to be desired.
That's most probably the very stupid redrawing I implemented quick and dirty. ("Redraw everything even after only setting a single dot."). I nearly finished the redesign if the software structure to enable minimal redrawing. Possibly a first preview will work this weekend, I'm curious if there is a noticable difference already.
Quote:Dunno what the blur thingy does (supposedly TV-Emu?), but it doesn't seem to have any effect here.
That's a very basic "PAL-Emulation" I implemented it around 2003 before I knew what a real PAL emulation should do. Yes, it's nothing more than a horizontal blur. Currently it's always on in the 1:1 preview window. In the main drawing window it can be switched on and off, but the difference can only be seen when the zoom is 1:1 or 2:1.
Quote:It would be nice too, adding the most common Plus/4 bitmap format: MultiBotticelli's.
Let me complete and fix the stuff already in the prog, then I'll think about what to do next. I'll add a feature request about this, so it can't get forgotten.
Thank you for your patience you have with this incomplete and buggy tool :) It'll get better sooner or later...
|
| |
Skoe
Account closed
Registered: Jan 2008
Posts: 34 |
Anybody with a Mac out there?
There's a new snapshot at Berlios which should improve the redrawing performance significantly and hopefully also resolves some redrawing bugs.
I checked it on Linux and Windows where it looks quite fast now. What redrawing issues are left on Mac?
The separate drawing window is still not included into the main window. That's what I'll do next.
|
| |
Edhellon
Registered: Aug 2003
Posts: 22 |
Definitely much snappier. DeeKay will have the final word though, as my iMac is pretty fast anyway. :)
BTW it seems when you close the editor window it's gone forever although you can save & continue editing in the preview window it's still a bit of a nag. Also, a shortcut (cmd+s) would be nice for save as well as displaying the current x/y char position (at least for us coders :) along the pixel coordinates. Also please get rid of the MDI interface next. :) Otherwise, keep up the good work! Once breakpoint is over I'll think about how to incorporate Oswald's conversion stuff from P1 and I guess by then you'll implement FLI/IFLI/drazlace/etc. :)
Edit: Duh, getting rid of the MDI stuff is next on your list, great! Should read before posting...
Edit #2: scrolling in the editor window doesn't work now with the mouse wheel (it used to work at least vertically) but hopefully it'll be a non-issue with the tab-interface. Also, most (probably all) my update bugs are gone, let's wait for DK's confirmation. |
| |
Skoe
Account closed
Registered: Jan 2008
Posts: 34 |
Quote:BTW it seems when you close the editor window it's gone forever although you can save & continue editing in the preview window it's still a bit of a nag.
That's a feature: After closing your hours-of-work-file without having it saved you can at least wave good-bye... Ahem, I noticed it but didn't want to fix it until I removed the MDI stuff.
Quote:Also, a shortcut (cmd+s) would be nice for save
I'm also a keyboard user. There should be a keyboard shortcut for almost everything. I'll have a look at those of P1 and think about using similar. Or are there better ideas? (Please don't ask for making them configurable, I don't have that many time)
Quote:as well as displaying the current x/y char position (at least for us coders :) along the pixel coordinates
Yep.
Quote:Edit #2: scrolling in the editor window doesn't work now with the mouse wheel (it used to work at least vertically) but hopefully it'll be a non-issue with the tab-interface. Also, most (probably all) my update bugs are gone, let's wait for DK's confirmation.
Search for #ifdef MC_NOT_YET. It's not implemented fully, that's why it's commented out. I plan to do scrolling controlled by moving the mouse to the edge of the window. Have to try it first to see how it feels.
So, have to go to work now. Thanks for your test.
|
| |
Alias Medron
Registered: Dec 2001
Posts: 39 |
Great tool!
don't know why but i like it more than project one..
only one request ..
is it possible change the keys for color selection to the keys used in amica paint?? (i paint for over 15 years in amica paint and some habbits are hard to change) |
