| |
Digger
Registered: Mar 2005
Posts: 436 |
Opensourcing CSDb
2020 has arrived, time to opensource CSDb.
Contributors could submit PR with improvements, patches, bug-fixes, features etc.
The "mighty" moderators (with Perff) can approve PRs and merge to production. Easy.
Let's use community powers to finally fix this mess. We deserve the best looking and working C64 community/preservation site ever.
Throw some stones please. |
|
| |
iAN CooG
Registered: May 2002
Posts: 3193 |
/me throws stones at Digger
seems fun |
| |
Flavioweb
Registered: Nov 2011
Posts: 463 |
This is the cathedral, not the bazaar. |
| |
Oswald
Registered: Apr 2002
Posts: 5094 |
good idea. should have happened 10 years ago. |
| |
Raistlin
Registered: Mar 2007
Posts: 680 |
Excellent idea! Will be great to see what people come up with. I’ve never seen this used on websites - presumably the mods will then be able to see/test PRs before they’re approved and integrated..? |
| |
Oswald
Registered: Apr 2002
Posts: 5094 |
"I’ve never seen this used on websites"
thats a point, perhaps not possible because of security. |
| |
Digger
Registered: Mar 2005
Posts: 436 |
Haha Oswald you’re still stuck in last decade. GitLab can store keys but they’re not in the source code.
Raistlin: its not a website, it’s PHP 🤣 We go full CI/CD with it |
| |
Oswald
Registered: Apr 2002
Posts: 5094 |
@Digger, I have no clue about web dev :) |
| |
Pararaum
Registered: Sep 2018
Posts: 11 |
Good idea. And a code review for security... I hate changing my password... :-) |
| |
Mr.Ammo
Account closed
Registered: Oct 2002
Posts: 228 |
Quoting Raistlin I’ve never seen this used on websites [sniip] Broaden your horizon! Pouet.net is just one example of a website / application that's open sourced and has worked with pull requests. Have a look at their repo: https://github.com/pouetnet/pouet2.0 |
| |
Digger
Registered: Mar 2005
Posts: 436 |
@Mr.Ammo Great example, it shows pull requests work with PHP xD |
| |
Digger
Registered: Mar 2005
Posts: 436 |
Contacted Perff \o/ |
| |
Perplex
Registered: Feb 2009
Posts: 255 |
This already exists, it's at https://github.com/demozoo/demozoo |
| |
Golara
Account closed
Registered: Jan 2018
Posts: 212 |
hmm, kinda split on that. I personally have no issues with the site and I don't want it to turn into another generic phone app like website. |
| |
hedning
Registered: Mar 2009
Posts: 4731 |
Quote: This already exists, it's at https://github.com/demozoo/demozoo
Has no warez |
| |
Perplex
Registered: Feb 2009
Posts: 255 |
Quoting hedningHas no warez
The site doesn't, but the code is open-source. |
| |
Digger
Registered: Mar 2005
Posts: 436 |
Yet another initiative by Chordian (JCH) improving the CSDb browsing experience.
http://csdb.chordian.net |
| |
hedning
Registered: Mar 2009
Posts: 4731 |
Quote: Yet another initiative by Chordian (JCH) improving the CSDb browsing experience.
http://csdb.chordian.net
Yes. A wrapper around the database itself is probably the way to go. I don't believe in any form of "new csdb" or a breakout of the database. over 20 releases and other info are added each day here, and it would be horrible to keep track of which version and variant that has the most complete data.
I get the impression that the people that want updates are looking for a more modern look, and a smoother experience, and are not the kind of users that actively add content to the database, or in other ways are contributing to the database work by spending time on updating info and entries. That is why C64 Scene by Mr.SID or JCH's project is the way to go. Keeping CSDb intact but gives the ones that feel a need for a more modern look what they "need". :)
If you need all content locally we have Assembly64 with weekly updates, which is a great thing to avoid constant scraping. |
| |
chatGPZ
Registered: Dec 2001
Posts: 11384 |
Modernizing the db structure itself is more needed than anything else. Throwing more dump on the pile isnt what will save it. Modern interface without fixing the core problem is just polishing turd. |
| |
hedning
Registered: Mar 2009
Posts: 4731 |
Quote: Modernizing the db structure itself is more needed than anything else. Throwing more dump on the pile isnt what will save it. Modern interface without fixing the core problem is just polishing turd.
I would not call it a turd. But if it's a turd, it's a very popular turd, and the best turd we have, but you are correct when it comes to what should be prioritized. The important stuff here is the data, not the presentation per se. |
| |
chatGPZ
Registered: Dec 2001
Posts: 11384 |
Somehow these threads remind me a lot about the various VICE whining threads.
IE: open-sourcing doesn't solve the problem. There'd still be noone willing to help =P |
| |
Lubber
Registered: Jan 2002
Posts: 26 |
At least i would like to help out with a proper oauth2 implementation or at least to enhance/fix the current website auth API implementation perff did some years ago.
Try here
 |
| |
chatGPZ
Registered: Dec 2001
Posts: 11384 |
"You are not logged into CSDb or denied access to request CSDb information"
i am logged in and i dont see an option to deny or allow access anywhere :) |
| |
Lubber
Registered: Jan 2002
Posts: 26 |
Yeah, thats what i meant by helping to fix it.
The code just calls perffs api and that tells me you are not logged in.. which is obviously wrong then
Did you try to login via the blue button and login form? At least it works for me then after entering my csdb credentials and shows my csdb information |
| |
chatGPZ
Registered: Dec 2001
Posts: 11384 |
You dont expect me to type my login data into that form, do you? =) |
| |
iAN CooG
Registered: May 2002
Posts: 3193 |
Don't worry, it's for SCIENCE!11!11! |
| |
Lubber
Registered: Jan 2002
Posts: 26 |
Quote: You dont expect me to type my login data into that form, do you? =)
You can, try with fake data if you don't trust me and watch the network console in the browser to see where the request goes: No data is transferred to my domain, it's all transferred directly to the csdb domain API urls.
I use the same example JS code that perff provides in his docs.
Again: A proper oauth2 with dedicated login form from the csdb site itself would help here |
| |
chatGPZ
Registered: Dec 2001
Posts: 11384 |
The general rule is to not enter login data anywhere, except the original site. Period. |
| |
Lubber
Registered: Jan 2002
Posts: 26 |
Quote: The general rule is to not enter login data anywhere, except the original site. Period.
Yes, absolutely correct!
Another reason to have a proper oauth2 implementation with a login form directly from csdb.dk as initially suggested :D
The current implementation by perff unfortunately does it the unsecure way as you pointed out. That's probably also the reason why it seems no c64 related website every really implemented it. (also i didn't, that was just a testpage anyway)..let's stop the discussion about this now. :) |
| |
Zyron
Registered: Jan 2002
Posts: 2381 |
It's better if you PM Perff about it. |
