[CSDb] - User Forums - Code indenting

You are not logged in - nap

CSDb User Forums

Forums > C64 Coding > Code indenting

2017-09-11 07:40

oziphantom

Registered: Oct 2014
Posts: 490

Code indenting

I've always been a strict

label code comment

kinda guy but of late I've been experimenting with code readability and speed boosts. Indenting does seem to improve things

updateMovement
	ldx Ents.movementPtr
-	lda YXDeltas,x
	cmp #$AA
	bne +
	ldx Ents.movementPtrBase
	stx Ents.movementPtr
	jmp -
+	clc
	adc Ents.y
	sta Ents.y
	inx	
	lda YXDeltas,x
	beq _endAdd
	bmi _sub
	clc
	adc Ents.x
	sta Ents.x
	bcc _endAdd
	inc Ents.xMSB
	jmp _endAdd
_sub
	clc
	adc Ents.x
	sta Ents.x
	lda Ents.xMSB
	adc #$ff
	sta Ents.xMSB
_endAdd
	inx
	stx Ents.movementPtr
	rts

updateMovement
	ldx Ents.movementPtr
-	lda YXDeltas,x
	cmp #$AA
	bne +
	    ldx Ents.movementPtrBase
	    stx Ents.movementPtr
	jmp -
+	clc
	adc Ents.y
	sta Ents.y
	inx	
	lda YXDeltas,x
	beq _endAdd
	    bmi _sub
                clc
                adc Ents.x
                sta Ents.x
                bcc _endAdd
                    inc Ents.xMSB
                    jmp _endAdd
       _sub
            clc
            adc Ents.x
            sta Ents.x
            lda Ents.xMSB
            adc #$ff
            sta Ents.xMSB
_endAdd
	inx
	stx Ents.movementPtr
	rts

this kind of falls apart when you get the to the leap frog code. I.e something like

bmi C
beq B
A
A
A
bne C
A
A
jmp D
B
B
B
B
beq D
C
C
C
C
D
D
D

So I was wondering if anybody else had tumbled down this rabbit hole or had other things to do to help?

... 20 posts hidden. Click here to view all posts....

2017-09-19 16:15

chatGPZ

Registered: Dec 2001
Posts: 11386

Quote:

when it goes all spaghetti

i recommend a bit of good oil, cheese, and red wine :)

2017-09-20 05:20

ChristopherJam

Registered: Aug 2004
Posts: 1409

I was going to stay out of this thread, as I tend not to indent asm blocks. Then I caught myself doing this last night:

for i in 1..30
{
    ldx so+i
    lda yv,x
    ldy so+i-1
    cmp yv,y
    bge next
        sty so+i
        ldy so+i-2
        cmp yv,y
        bge swap1
            sty so+i-1
            ldy so+i-3
            cmp yv,y
            bge swap2
                jmp abort
        swap2
            stx so+i-2
            jmp reload
    swap1
        stx so+i-1
reload
    ldx so+i
next
}
  ; 51 bytes per pair, *31 = 1550 bytes (less a bit for the first few entries)

(code may contain bugs, and is wrong for i in 1..2 and also I want to swap x & y every second iteration of the code generator so I can drop the "ldy so+i-1" on subsequent iters, but those are all by the by)

2017-09-22 00:10

Cruzer

Registered: Dec 2001
Posts: 1048

Quoting Compyx

asm doesn't have block-level scope. And if there are assemblers that support that, those are retarded.

I dunno. If it's used for keeping the code organized, I beg to differ. For instance I like to keep each subroutine in braces, so I can have local labels like "loop" and "done" that would otherwise have to be either global (I remember the days of turbo-ass and having to come up with meaningless labels like "loop43") or multi-labels referenced by label+ or label-, which have the disadvantage that if you forget to add the label, it usually ends up referring to a label in another subroutine. But even when using multi-labels you avoid this if the subroutines are in different blocks, since it will just give a compile time error.

Are for-loops and other scripting retarded? Certainly if it's used for generating speedcode or data that could be generated quicker at runtime than it would take to load. But for importing gfx or generating small chunks of data or code such as setting the y-position of 8 sprites it makes a lot of sense to me.

Previous - 1 | 2 | 3 - Next

Refresh

Subscribe to this thread: