| |
jailbird
Registered: Dec 2001 Posts: 1578 |
A minimalistic CSDb style for Stylish
I couldn't sleep last night so I decided to restyle CSDb a bit, maybe some of you will find it useful.
Since the HTML is not semantic at all, and it was a real pain in the ass to make it work, I am pretty sure it's full of shit, so feel free to improve/change it.
Oh, and it works only when you're logged in.
Get it from https://github.com/csisztaiarnold/csdb_stylish
Preview on YouTube: https://www.youtube.com/watch?v=mLMcTCREKf8 |
|
| |
Oswald
Registered: Apr 2002 Posts: 5094 |
looks great, extra thumbs for the joke :) |
| |
Digger
Registered: Mar 2005 Posts: 436 |
Awesome selector gang-bang JB! It used to be Greasemonkey doing this in 2000. |
| |
Hein
Registered: Apr 2004 Posts: 954 |
That's too freaking pragmatic for this database.
|
| |
Shadow Account closed
Registered: Apr 2002 Posts: 355 |
Nice work Jailbird, a little more modern feel to it compared to standard CSDb! |
| |
CreaMD
Registered: Dec 2001 Posts: 3057 |
Neat, I think now when it is proof-of-concepted (is that the term?) it might also be replaced for CSDB by Perff ;-) I kinda like it, although I only clicked through the video. If that's also responsive, immediate replacement is a must. |
| |
chatGPZ
Registered: Dec 2001 Posts: 11384 |
verdammte webdesignspacken |
| |
jailbird
Registered: Dec 2001 Posts: 1578 |
Quote: Neat, I think now when it is proof-of-concepted (is that the term?) it might also be replaced for CSDB by Perff ;-) I kinda like it, although I only clicked through the video. If that's also responsive, immediate replacement is a must.
Nah, due to the archaic, nested table structure, the inline styles and the total absence of semantics, it's impossible to make it responsive with CSS only (except from hiding stuff with media queries). Inportant sections which would need isolated block-elements or groupings are often separated by line breaks or empty table cells. Also, almost all the input buttons are made of images. The HTML would definitely need a rewrite from ground up.
And even when I use targeted selectors for styling specific elements, there is a great chance that the same selector will affect another element on another page as they're often conflicting.
So in the current state of CSDb, we're limited to play around with whitespaces, colors and font styles. That's about it.
The first version was rather fast experiment to check out what's possible with Stylish, but I keep tinkering with the style, so you could expect a better version soon |
| |
jailbird
Registered: Dec 2001 Posts: 1578 |
Updated the forum area:
Forum table > Topics table > Thread |
| |
CreaMD
Registered: Dec 2001 Posts: 3057 |
Beauty. |
| |
jailbird
Registered: Dec 2001 Posts: 1578 |
I have added the stylesheet to userstyles.org, so from now on, once you have installed both the extension and the style, you could always be up do date with the latest production version of the sheet (Manage installed styles > Check for update).
It's still a work in progress, so use it with caution.
Installation instructions: https://github.com/csisztaiarnold/csdb_stylish#installation
There's no Stylish plugin for IE/Edge, but I guess it could be substituted with Greasemonkey. |
| |
bOOZElEE
Registered: Dec 2002 Posts: 35 |
Quoting JailbirdThe HTML would definitely need a rewrite from ground up.
I second that.
It'd be great to make an overhaul and switch to semantic and responsive HTML5 markup.
I can listen to SID-Tunes on my phone, why shouldn't I be able to read CSDb properly on it ;) |
| |
chatGPZ
Registered: Dec 2001 Posts: 11384 |
you should be making gfx instead :) |
| |
bOOZElEE
Registered: Dec 2002 Posts: 35 |
Oh c'mon, sweetheart. It's my 24th post in about 15 years and I'm still being ranted at by you, just for being inactive ;)
But seriously: if (part) of the source code would be made available (f.e. in a repository) there should be imho enough people willing to help switching to a more semantic approach.
Unless there's something I'm not aware off and html table layout is still necessary? People using AWeb or IBrowse on AMIGA f.e.? :) |
| |
jailbird
Registered: Dec 2001 Posts: 1578 |
WTF, I'd never thought I'd communicate, nevertheless to agree with Rayden, but yeah.
My current shit is somewhat bareable. It is better, but it IS... shit.
As is CSDb.
Do better |
| |
jailbird
Registered: Dec 2001 Posts: 1578 |
BTW a single class on the <body> depending on the first URI segment would help ALFULLY a lot! Perffffff pls! |
| |
jailbird
Registered: Dec 2001 Posts: 1578 |
Plus another update :
- it looks better (except the PM, but who uses that anyway)
- votes look better:
And similar small improvement stuff but I have to pee and sleep |
| |
chatGPZ
Registered: Dec 2001 Posts: 11384 |
Quote:But seriously: if (part) of the source code would be made available (f.e. in a repository) there should be imho enough people willing to help switching to a more semantic approach.
after looking at the code myself, i dare to say that those who look at it only want to do one thing: delete it all. |
| |
JackAsser
Registered: Jun 2002 Posts: 2014 |
Quote: Quote:But seriously: if (part) of the source code would be made available (f.e. in a repository) there should be imho enough people willing to help switching to a more semantic approach.
after looking at the code myself, i dare to say that those who look at it only want to do one thing: delete it all.
That is indeed usually the case when it comes to bad code. The only viable approach would be to expose the content of the database as an API imo (since giving the full database exposes private messages between persons etc).
Another approach is of course to gut out everything personal from the database and keep it a pure tracking of releases (i.e. remove PMs, forum, user comments) then make everything public domain with public read only access. Read write access for selected trusted implementors. |
| |
chatGPZ
Registered: Dec 2001 Posts: 11384 |
even the db itself needs a serious rework / restructuring.
think of the C code you wrote 20 years ago. its that bad. |
| |
Peacemaker
Registered: Sep 2004 Posts: 275 |
Jailbird: Looking good. If you it could only beeing applied by inserting your .css why, not? :D |
| |
CreaMD
Registered: Dec 2001 Posts: 3057 |
Quote: BTW a single class on the <body> depending on the first URI segment would help ALFULLY a lot! Perffffff pls!
Jb, contact Perff directly, that should be a simple and straightforward task for him.
Other way, parse url with js, add body class dynamically with js. (using js not possible, right?)
roman |
| |
Perff Administrator
Posts: 1679 |
Nice things I see people are saying about my old code here! ;)
But, yes it IS bad. :/
@Jailbird: Let me know what you like me to do (didn't get it from your comment), and I'll look at it. :) |
| |
chatGPZ
Registered: Dec 2001 Posts: 11384 |
I'd say exactly the same about my own code from 20 years ago. Horrible =) |
| |
jailbird
Registered: Dec 2001 Posts: 1578 |
HTML and CSS aint code anyway ;)
@Perff: I/we would need a unique (but permanent) class in the body of each page based on the first URI segment. Fe. forum for this, home for home, release for the release page, event for the events, etc. So I could write direct selectors which don't influence elements on other pages. I am sure it would be easy to automate it. Thanx! XOXO
Ps: plus a unique class for the menu items, but that's useful just for the lurkers so no priority |
| |
bOOZElEE
Registered: Dec 2002 Posts: 35 |
Quoting JailbirdWTF, I'd never thought I'd communicate, nevertheless to agree with Rayden, but yeah.
Nonetheless you're welcome :)
I highly appreciate the work you put into the CSS, but the stylish approach feels to me like a Bondo Bucket: shiny at the first glance, but as the base isn't solid she starts falling apart if you take her out for the first ride in town ;)
But it cleary shows what could (and imho should) be done to give CSDb a more contemporary look and feel. I like.
A repository/archive just containing the current templates (no DB involved) would be a first step - just to take a look at the current code. But given the age of the code, I suspect some fancy interwoven HTML/PHP stuff and I doubt I really want to see it... ;) (@Perff: no offence meant) |
| |
chatGPZ
Registered: Dec 2001 Posts: 11384 |
hardcoded permissions anyone? :o) |
| |
Mixer
Registered: Apr 2008 Posts: 449 |
We also need a style that uses only the c-64 system font and petscii graphics. |
| |
Hein
Registered: Apr 2004 Posts: 954 |
Quote: HTML and CSS aint code anyway ;)
@Perff: I/we would need a unique (but permanent) class in the body of each page based on the first URI segment. Fe. forum for this, home for home, release for the release page, event for the events, etc. So I could write direct selectors which don't influence elements on other pages. I am sure it would be easy to automate it. Thanx! XOXO
Ps: plus a unique class for the menu items, but that's useful just for the lurkers so no priority
That sounds easier than doing a rewrite from ground up. Can't be good. |
| |
jailbird
Registered: Dec 2001 Posts: 1578 |
Quote: That sounds easier than doing a rewrite from ground up. Can't be good.
Definitely not good. The current situation is, CSDb doesn't have CSS at all. Everything is inline, but not even stlye. font="#fff" stuff and similar, in layers and layers of nested tables.
But. I don't think it will be ever rewritten.
Seems that this is the only way to make changes. |
| |
Compyx
Registered: Jan 2005 Posts: 631 |
Looked at the HTML source, and indeed there's a lot deprecated stuff in there.
Then again, I tend to drop out off/into the scene and CSDb looking exactly the same after ten years makes me feel right at home. So I'm fine with the current look. |
| |
hedning
Registered: Mar 2009 Posts: 4731 |
I love CSDb just as it is. Make demos for the C64 instead. |
| |
Mekong Account closed
Registered: Mar 2013 Posts: 6 |
Aside from the votes, looks like a downgrade to me. CSDb is probably the only site where I don't have to block any elements and can exempt the original style from the dark custom one I use for everything else. I wish the rest of the Internet was this "outtdated" as in displaying content quickly, clearly and on any system. |
| |
Hein
Registered: Apr 2004 Posts: 954 |
|
| |
Perff Administrator
Posts: 1679 |
Quoting JailbirdHTML and CSS aint code anyway ;)
@Perff: I/we would need a unique (but permanent) class in the body of each page based on the first URI segment. Fe. forum for this, home for home, release for the release page, event for the events, etc. So I could write direct selectors which don't influence elements on other pages. I am sure it would be easy to automate it. Thanx! XOXO
Ps: plus a unique class for the menu items, but that's useful just for the lurkers so no priority
Put in a class in the body as requested. Hope you can use it. :) |
| |
jailbird
Registered: Dec 2001 Posts: 1578 |
Quote: I love CSDb just as it is. Make demos for the C64 instead.
I don't know how to code, that's why I do HTML :)
Quoting PerffPut in a class in the body as requested. Hope you can use it. :)
AMAZING! THANX A LOT!
Quoting MekongAside from the votes, looks like a downgrade to me.
Exactly, hence the "minimal" in its project title :) |